Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api/build/v8): Use blob to build v8 #5146

Merged
merged 6 commits into from
Oct 16, 2024
Merged

feat(api/build/v8): Use blob to build v8 #5146

merged 6 commits into from
Oct 16, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Oct 16, 2024

wee8-custom-builds is a repo akin to llvm-custom-builds that builds v8 in wee8 mode producing an archive containing the necessary static libraries to build wasmer with the v8 feature enabled.

This patch

  1. removes the v8-cmake submodule
  2. downloads the archive and uses its contents during linking
  3. introduces a copy of the wasm.h header from the v8 repo

@xdoardo xdoardo requested a review from syrusakbary as a code owner October 16, 2024 11:59
@xdoardo xdoardo merged commit 610b138 into release-5.0 Oct 16, 2024
67 of 70 checks passed
@xdoardo xdoardo deleted the wee8-use-blob branch October 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants