feat(api/build/v8): Use blob to build v8

.github/workflows/test.yaml

@@ -272,6 +272,10 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
+      - name: Setup MSVC (Windows) 
+        uses: ilammy/msvc-dev-cmd@v1
+        if: matrix.metadata.build == 'windows-x64'
+
       - uses: dtolnay/rust-toolchain@stable
         with:
           toolchain: ${{ env.MSRV }}
@@ -297,9 +301,10 @@ jobs:
         run: |
           choco install ninja
 
-      - name: Setup MSVC (Windows) 
-        uses: ilammy/msvc-dev-cmd@v1
-        if: matrix.metadata.build == 'windows-x64'
+      - name: Delete unwanted link to stop it from interfering (Windows) 
+        shell: bash
+        run: rm /usr/bin/link.exe
+        if: startsWith(matrix.metadata.build, 'windows-')
 
       - name: Test WAMR API 
         if: ${{ matrix.build-what.key == 'wamr' }}

Makefile

@@ -580,7 +580,7 @@ test-examples: test-stage-5-test-examples test-stage-6-test-examples-release
 test-v8: test-v8-api
 
 test-v8-api:
-	cargo nextest run --package=wasmer --release --features=v8 --no-default-features
+	CARGO_TERM_VERBOSE=true cargo nextest run --package=wasmer --release --features=v8 --no-default-features
 
 test-wamr: test-wamr-api
 

lib/api/Cargo.toml

@@ -150,7 +150,9 @@ static-artifact-create = ["wasmer-compiler/static-artifact-create"]
 [build-dependencies]
 bindgen = "0.70.1"
 cmake = "0.1.50"
+tar = "0.4.42"
 ureq = "2.10.1"
+xz = "0.1.0"
 zip = "2.2.0"
 
 [package.metadata.docs.rs]

lib/api/build.rs

@@ -148,58 +148,41 @@ fn main() {
 
     #[cfg(feature = "v8")]
     {
-        use cmake::Config;
         use std::{env, path::PathBuf};
 
+        let url = match (env::var("CARGO_CFG_TARGET_OS").unwrap().as_str(), env::var("CARGO_CFG_TARGET_ARCH").unwrap().as_str()) {
+            ("macos", "aarch64") => "https://github.com/wasmerio/wee8-custom-builds/releases/download/11.6/wee8-darwin-aarch64.tar.xz",
+            ("macos", "x86_64") => "https://github.com/wasmerio/wee8-custom-builds/releases/download/11.6/wee8-darwin-amd64.tar.xz",
+            ("linux", "x86_64") => "https://github.com/wasmerio/wee8-custom-builds/releases/download/11.6/wee8-linux-amd64.tar.xz",
+            ("windows", "x86_64") =>"https://github.com/wasmerio/wee8-custom-builds/releases/download/11.6/wee8-windows-amd64.tar.xz",
+            (os, arch) => panic!("target os + arch combination not supported: {os}, {arch}")
+        };
+
         let crate_root = env::var("CARGO_MANIFEST_DIR").unwrap();
-        let v8_cmake_dir = PathBuf::from(&crate_root)
-            .join("third_party")
-            .join("v8-cmake");
-
-        let mut fetch_submodules = std::process::Command::new("git");
-        fetch_submodules
-            .current_dir(crate_root)
-            .arg("submodule")
-            .arg("update")
-            .arg("--init")
-            .arg("--recursive");
-
-        let res = fetch_submodules.output();
-
-        if let Err(e) = res {
-            panic!("fetching submodules failed: {e}");
-        }
+        let v8_dir = PathBuf::from(&crate_root).join("third_party").join("v8");
+        let out_dir = env::var("OUT_DIR").unwrap();
 
-        let mut dst = Config::new(v8_cmake_dir.clone());
+        let tar = ureq::get(url).call().expect("failed to download v8");
 
-        dst.always_configure(true)
-            .generator("Ninja")
-            .define(
-                "CMAKE_BUILD_TYPE",
-                if cfg!(debug_assertions) {
-                    "RelWithDebInfo"
-                } else {
-                    "Release"
-                },
-            )
-            .build_target("wee8");
+        let mut tar_data = Vec::new();
+        tar.into_reader()
+            .read_to_end(&mut tar_data)
+            .expect("failed to download v8 lib");
 
-        if cfg!(target_os = "windows") {
-            dst.define("CMAKE_CXX_COMPILER", "cl.exe");
-            dst.define("CMAKE_C_COMPILER", "cl.exe");
-            dst.define("CMAKE_LINKER_TYPE", "MSVC");
-            dst.define("WAMR_BUILD_PLATFORM", "windows");
+        let tar = xz::read::XzDecoder::new(tar_data.as_slice());
+        let mut archive = tar::Archive::new(tar);
+
+        for entry in archive.entries().unwrap() {
+            eprintln!("entry: {:?}", entry.unwrap().path());
         }
 
-        let dst = dst.build();
+        let tar = xz::read::XzDecoder::new(tar_data.as_slice());
+        let mut archive = tar::Archive::new(tar);
+
+        archive.unpack(out_dir.clone()).unwrap();
+
+        println!("cargo:rustc-link-search=native={}", out_dir);
 
-        // Check output of `cargo build --verbose`, should see something like:
-        // -L native=/path/runng/target/debug/build/runng-sys-abc1234/out
-        // That contains output from cmake
-        println!(
-            "cargo:rustc-link-search=native={}",
-            dst.join("build").display()
-        );
         println!("cargo:rustc-link-lib=wee8");
         println!("cargo:rustc-link-lib=v8_initializers");
         println!("cargo:rustc-link-lib=v8_libbase");
@@ -214,17 +197,15 @@ fn main() {
             println!("cargo:rustc-link-lib=stdc++");
         } else if cfg!(target_os = "windows") {
             /* do nothing */
+            println!("cargo:rustc-link-lib=winmm");
+            println!("cargo:rustc-link-lib=dbghelp");
+            println!("cargo:rustc-link-lib=shlwapi");
         } else {
             println!("cargo:rustc-link-lib=c++");
         }
 
         let bindings = bindgen::Builder::default()
-            .header(
-                v8_cmake_dir
-                    .join("v8/third_party/wasm-api/wasm.h")
-                    .to_str()
-                    .unwrap(),
-            )
+            .header(v8_dir.join("wasm.h").to_str().unwrap())
             .derive_default(true)
             .derive_debug(true)
             .generate()