fix(journal): Correctly handle client socket closing during compaction #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
force-pushed
the
issue-4839-socket-compaction
branch
from
5862826 to
2df151c
Compare
syrusakbary
reviewed
Jun 12, 2024
Previously outbound sockets were not properly recorded as open in the compactor, and thus closed sockets were not properly removed from the journal. This change implements tracking for sockets after connecting to them.
theduke
force-pushed
the
issue-4839-socket-compaction
branch
from
2df151c to
d3ea1c4
Compare
They were already commented out, I un-commented the runner and added a new test. Followup should fix up the other tests. |
syrusakbary
approved these changes
Jun 17, 2024
|
@john-sharratt for posterity, I phrased it a bit incorrectly: before, non of the tests were running because they were gated behind the The journal crate doesn't have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously outbound sockets were not properly recorded as open in the
compactor, and thus closed sockets were not properly removed from the
journal.
This change implements tracking for sockets after connecting to them.
Closes #4839