feat: wasmer-config #4582
Merged
feat: wasmer-config #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new wasmer-config create, which: * Supersedes the wasmer-toml crate * Includes the app.yaml configuration schema Compared to the original upstream wasmer-toml, this PR includes the following additions: * new types for packages (PackageSource, PackageId, PackageIdent, Sha256Hash, PackageHash, ...) * `AppConfigV1`, which describes the format of `app.yaml` files The motivation for inclusion is to: * Simplify management so we don't have to maintain another repository * Expand the scope of the crate to include additional Wasmer related configuration - we would oterhwise need to maintain additional crates The PR also adds a new Github workflow for checking the crate.
xdoardo
reviewed
Apr 17, 2024
There was a problem hiding this comment.
I think that this file could be named named_package.rs or - not ideal, I know - to keep the congruence with the names of other files, package_named.rs. The rationale for this is that it'd be easy to confuse this file (thus module as well) with package_ident.rs.
There was a problem hiding this comment.
The main type in the module is PackageId (and NamedPackageId), so that name suggestion seems more confusing to me.
The duplication between PackageId and Ident is suboptimal indeed, but one is a loose specification with version ranges etc, while the other is just a concrete single package version.
syrusakbary
reviewed
Apr 17, 2024
syrusakbary
reviewed
Apr 17, 2024
syrusakbary
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new wasmer-config create, which:
Compared to the original upstream wasmer-toml, this PR includes the
following additions:
Sha256Hash, PackageHash, ...)
AppConfigV1, which describes the format ofapp.yamlfilesThe motivation for inclusion is to:
configuration - we would oterhwise need to maintain additional crates
The PR also adds a new Github workflow for checking the crate.
Closes #4553