Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmer_config::package::PackageHash - Refactor to enum #4585

Closed
theduke opened this issue Apr 17, 2024 · 0 comments
Closed

wasmer_config::package::PackageHash - Refactor to enum #4585

theduke opened this issue Apr 17, 2024 · 0 comments
Labels
cleanup Lets clean up the code!
Milestone
backlog

Comments

@theduke
Copy link
Contributor

theduke commented Apr 17, 2024

Refactor the PackageHash type to be an enum.

Note: the inner field is currently private, so refactoring to an enum should be possible without a breaking change.

The enum should be #[non_exhaustive].

Originally posted by @syrusakbary in #4582 (comment)
@theduke theduke mentioned this issue Apr 17, 2024
Merged
@syrusakbary syrusakbary added this to the v4.4 milestone Apr 23, 2024
@syrusakbary syrusakbary added the cleanup Lets clean up the code! label Apr 23, 2024
PappuPanaut pushed a commit to PappuPanaut/wasmer that referenced this issue May 17, 2024
@MT23046
wasmer_config::package::PackageHash - Refactor to enum wasmerio#4585
2257499
@PappuPanaut PappuPanaut mentioned this issue May 17, 2024
Merged
@syrusakbary syrusakbary mentioned this issue Oct 3, 2024
Closed
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Lets clean up the code!
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
2 participants
@syrusakbary @theduke