Metering. #450
Merged
Metering. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed |
|
bors try |
bjfish
reviewed
May 17, 2019
| @@ -92,6 +92,8 @@ pub struct InternalCtx { | |||
|
|
|||
| pub memory_base: *mut u8, | |||
| pub memory_bound: usize, | |||
|
|
|||
| pub internals: *mut [u64; INTERNALS_SIZE], // TODO: Make this dynamic? | |||
There was a problem hiding this comment.
Should we consider embedding array?
There was a problem hiding this comment.
Internals are intended to be statically allocated to middleware modules. I think a fixed-size array would be suitable for this case.
bjfish
reviewed
May 17, 2019
|
bors try |
tryMerge conflict |
bjfish
reviewed
Jun 2, 2019
|
bors try |
|
bors try |
bors bot
added a commit
that referenced
this pull request
Jun 5, 2019
481: Added context trampoline into runtime r=losfair a=syrusakbary Based on #450 Co-authored-by: losfair <[email protected]>
|
bors try |
bjfish
approved these changes
Jun 7, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 7, 2019
450: Metering. r=bjfish a=losfair TODO - [x] Add test to verify points used after function call - [x] Add test to verify function call will trap - [x] Add documentation Co-authored-by: losfair <[email protected]> Co-authored-by: Brandon Fish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO