Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metering. #450
Metering. #450
Changes from 7 commits
6aa87a0
7e79dd2
e7297b9
14fcd78
b830f10
8e0d71b
6aec1c4
cf58305
dcf52ef
9919dd7
68a8800
fd86753
b834b4f
8019505
c1e817b
f029ea6
995ecef
e533a8a
c020c39
f9c8f41
8fdc4f9
0c3109f
605c0dc
151af82
66f9049
69944c1
0867208
f2d8aad
f5243af
f832c8d
27eacf0
c6cd49a
418764a
e87d507
f6ecfa4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove debugging printlns before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider embedding array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internals are intended to be statically allocated to middleware modules. I think a fixed-size array would be suitable for this case.