chore: Completely remove wasix_http_client #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
requested changes
Feb 28, 2024
theduke
force-pushed
the
wasix-http-client-remove-full
branch
from
e472530 to
5db5f7c
Compare
Followup to a previous removal commit. This now completely removes all usage of wasix_http_client. (exported definitions, implementations, etc)
theduke
force-pushed
the
wasix-http-client-remove-full
branch
from
5db5f7c to
6ff2f3c
Compare
syrusakbary
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to a previous removal commit.
This now completely removes all usage of wasix_http_client.
(exported definitions, implementations, etc)
Also removes the related wai-bindgen-gen-wasmer crate, which is not
needed anymore.
Followup to #4466
NOTE: removing the
wai-bindgen-gen-wasmercrate is essentially an admission that WAI is unmaintained , and will not receive future development.I think this is the right move.