Clean up wasmer-wasix-types and remove wasix-http-client #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the experimental WAI http client bindings. These were not used anywhere, and have significant problems. This shold be replaced by the WIT http bindings in the future.
The WAI schema based code generation was used previously, but has not been functioning for quite a while. We have lots of manually defined types instead. The codegen also required heavy patching to work in the first place. Since this is a dead end, the automatic codegen is removed, since it is dead code.
Arshia001
approved these changes
Feb 27, 2024
syrusakbary
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Remove WAI codegen from wasmer-wasix-types
The WAI schema based code generation was used previously, but has not
been functioning for quite a while.
We have lots of manually defined types instead.
The codegen also required heavy patching to work in the first place.
Since this is a dead end, the automatic codegen is removed.
We may replace this with a more suitable solution in the future.
chore: Remove wasix-http-client
Remove the experimental WAI http client bindings.
These were not used anywhere, and have significant problems.
This shall be replaced by the WIT wasi-http bindings in the future.