Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Add package commands #4287

Merged
merged 4 commits into from
Nov 13, 2023
Merged

feat(cli): Add package commands #4287

merged 4 commits into from
Nov 13, 2023

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Oct 31, 2023 •
edited
Loading

Adds new CLI commands for working with packages:

  • package download: download package from registry
  • package build: build a package from a wasmer.toml manifest
  • package unpack: extract package contents to a directory

@theduke theduke requested a review from syrusakbary as a code owner October 31, 2023 16:30
@theduke theduke force-pushed the feat-cli-package-download branch from 82152ca to dcaa2c1 Compare November 2, 2023 10:25
@theduke theduke changed the title feat(cli): Add "package dowload" command feat(cli): Add package commands Nov 2, 2023
@theduke theduke force-pushed the feat-cli-package-download branch 3 times, most recently from cc312f1 to 2c9ef76 Compare November 2, 2023 10:52
Michael-F-Bryan
Michael-F-Bryan suggested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this to the wasmer CLI. I've been wanting to do it for ages but never got around to it.

I've added some suggestions around coding style so it matches up with the rest of the CLI code.

lib/cli/src/commands/package/build.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/build.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/build.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/build.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/download.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/mod.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/unpack.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/unpack.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/unpack.rs Outdated Show resolved Hide resolved
lib/registry/src/wasmer_env.rs Show resolved Hide resolved
@theduke
feat(cli): Add package build/download/unpack commands
9f7b7eb 
Adds a new CLI command for working with packages:

* package download: download a package from a registry
* build: build a package from a wasmer.toml manifest
* unpack: extract package contents
@theduke theduke force-pushed the feat-cli-package-download branch from 2c9ef76 to ce154e5 Compare November 13, 2023 11:28
@theduke
fix(cli): Pass auth token when querying packages
2de48f4 
Need to pass an auth token to the package query, otherwise it would fail
due to not being able to query the private package.
@theduke theduke force-pushed the feat-cli-package-download branch from ce154e5 to 2de48f4 Compare November 13, 2023 11:36
Michael-F-Bryan
Michael-F-Bryan approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Nov 13, 2023
Closed
@Michael-F-Bryan Michael-F-Bryan merged commit 9275275 into master Nov 13, 2023
53 checks passed
@Michael-F-Bryan Michael-F-Bryan deleted the feat-cli-package-download branch November 13, 2023 13:29
@dynamite-bud dynamite-bud mentioned this pull request Nov 16, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theduke @Michael-F-Bryan