Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TTY-aware output to the wasmer package and wasmer container commands #4309

Closed
Michael-F-Bryan opened this issue Nov 13, 2023 · 0 comments · Fixed by #4315
Closed

Add TTY-aware output to the wasmer package and wasmer container commands #4309

Michael-F-Bryan opened this issue Nov 13, 2023 · 0 comments · Fixed by #4315
Assignees
@dynamite-bud
Labels
🎉 enhancement New feature! 🥇 good first issue Good for newcomers 📦 lib-cli About wasmer-cli linear Created by Linear-GitHub Sync priority-low Low priority issue
Milestone
backlog

Comments

@Michael-F-Bryan
Copy link
Contributor

In #4287 we added three new commands, wasmer container unpack, wasmer package download, and wasmer package build.

The commands currently use eprintln!() to show output, but ideally we'd do something more TTY-aware using the indicatif crate.

Some suggestions:

  • Show a spinner or progress bar while downloading and unpacking (we can probably use the Content-Length header, ProgressBar::set_length(), and ProgressBar::wrap_write() here)
  • Use ProgressBar::println() or ProgressBar::set_message() instead of the eprintln!() updates
  • Add a --quiet flag that hides output
@Michael-F-Bryan Michael-F-Bryan added 🎉 enhancement New feature! 🥇 good first issue Good for newcomers 📦 lib-cli About wasmer-cli priority-medium Medium priority issue linear Created by Linear-GitHub Sync labels Nov 13, 2023
@Michael-F-Bryan Michael-F-Bryan added this to the v4.3 milestone Nov 14, 2023
@Michael-F-Bryan Michael-F-Bryan added priority-low Low priority issue and removed priority-medium Medium priority issue labels Nov 14, 2023
@dynamite-bud dynamite-bud linked a pull request Nov 16, 2023 that will close this issue
Add TTY aware output to the wasmer package and wasmer container commands #4315
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dynamite-bud dynamite-bud

Labels
🎉 enhancement New feature! 🥇 good first issue Good for newcomers 📦 lib-cli About wasmer-cli linear Created by Linear-GitHub Sync priority-low Low priority issue
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

Add TTY aware output to the wasmer package and wasmer container commands wasmerio/wasmer
2 participants
@Michael-F-Bryan @dynamite-bud