Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes to support Wasmer JS #4192

Merged
merged 26 commits into from
Oct 30, 2023
Merged

More fixes to support Wasmer JS #4192

merged 26 commits into from
Oct 30, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Aug 31, 2023 •
edited
Loading

This PR adds a couple extra fixes that are needed to make wasmer-js work.

  • Replace the wasm_bindgen_downcast crate with our own implementation because Symbol-based type checking isn't thread safe - this meant we corrupt the heap if a trap is raised on one thread and consumed from another (e.g. via WasiRuntimeError::as_exit_code())
  • Fixes some broken links which get rejected by clippy when compiling to wasm32-unknown-unknown

@Michael-F-Bryan Michael-F-Bryan force-pushed the wasmer-js-fixes branch 2 times, most recently from 203e72e to ab71f9e Compare September 11, 2023 08:05
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Sep 14, 2023
Merged
@Michael-F-Bryan Michael-F-Bryan force-pushed the wasmer-js-fixes branch 3 times, most recently from f2135f4 to 24d971d Compare October 2, 2023 08:39
@Michael-F-Bryan Michael-F-Bryan force-pushed the wasmer-js-fixes branch 2 times, most recently from 3b2ddcb to 8ec4f1d Compare October 5, 2023 05:29
syrusakbary
syrusakbary approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review October 25, 2023 15:07
@syrusakbary
Copy link
Member

Tests are failing. We can fix and merge @Michael-F-Bryan

Michael-F-Bryan added 13 commits October 27, 2023 22:07
fix: Manually downcast JsValues back to traps because DowncastJS isn'…
3b76a81 
…t thread-safe
fix: Update some links that are broken when compiling for the browser
7b3847c
Remove the wasm-bindgen-downcast dependency
411bcaf
Made sure downcast_from_ptr() correctly consumes the Trap wrapper class
69f6aa0
Improve the error messages you get when memory creation fails
43acff5
Make sure we set the "maximum" parameter when creating shared memories
48f9458
Converting more log statements to structured logging
f380ed8
Fixed a deprecation warning from chrono
fb25c20
Removed unnecessary deref() calls to make some warnings go away
b6389d9
Added more JS conversions for Memory
d156bce
Made the js-only current_thread_id() polyfill available
8bad850
Added a ModuleHash::parse_hex() method
2048c16
Added some more Debug implementations
ff49951
Michael-F-Bryan added 11 commits October 27, 2023 22:08
Added a hack to WebHttpClient which lets you pass in a VirtualTaskMan…
293856f 
…ager to avoid deadlocking syscalls
Switch WasiRunner over to spawn_exec()
1dacae0
Explicitly updated the chrono dependency to pick up timestamp_nanos_o…
67ae201 
…pt()
Rustfmt
7caf0c3
Rewrote the WasiRunner tests to use threads provided by the Tokio run…
1be2ce5 
…time
Explicitly specify the version number for packages used in the runner…
a48706a 
… tests
Modified the runner tests to manually enter a tokio
e911b82
fix: Make sure spawn_exec() calls a named command and not just the en…
a2ba3ee 
…trypoint
Re-enable a BinaryPackage test
2550841
Made sure the wat2wasm runner test exercises stdout
665fc28
Fixed the bug in spawn_exec() where non-zero exit codes aren't propag…
b7ca81a 
…ated properly
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Oct 30, 2023
Open
@syrusakbary syrusakbary disabled auto-merge October 30, 2023 09:38
@syrusakbary syrusakbary merged commit 448a557 into master Oct 30, 2023
52 of 53 checks passed
@syrusakbary syrusakbary deleted the wasmer-js-fixes branch October 30, 2023 09:38
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-F-Bryan @syrusakbary