Running import asyncio with wasmer/[email protected] in the browser deadlocks
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏱ Workflow Timer ⏱ Make sure you keep an eye on build times! The goal is to keep CI times under 10 minutes so developers can maintain a fast edit-compile-test cycle.
🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer. |
Michael-F-Bryan
changed the title
import asyncio with wasmer/[email protected] in the browser blocks upimport asyncio with wasmer/[email protected] in the browser deadlocks
added 2 commits
January 5, 2024 15:48
…eep_now() method will never resolve when invoked from a syscall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason running
import asynciofrom Python causes the browser to lock up is because the__asyncifiy_with_deep_sleep()method blocking syscalls until a future resolves, but thesetTimeout()future fromThreadPool::sleep_now()never gets a chance to mark itself as resolved because the JavaScript VM is currently blocked by the syscall.This is very similar to the issue we had where
proc_exec()would block while waiting for a HTTP request to finish (see wasmerio/wasmer@293856f from wasmerio/wasmer#4192 for more).Fixes SDK-73.