fix: Make the "wasmer cache" command use the same cache directory as the rest of the CLI #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the
wasmer cachecommand was using acrate::common::get_cache_dir()helper to get the cache directory, but that helper isn't actually used by anything else (they all usewasmer_registry::wasmer_env::WasmerEnv) and automatically appends the current version number to$WASMER_DIR/cache.That means
wasmer cache cleanwould try to delete~/.wasmer/cache/4.1.1while the rest of the runtime was saving things to~/.wasmer/cache/compiled,~/.wasmer/cache/downloads, and so on.Fixes #4093.