Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmer cache clean/dir doesn't seem to care .wasmer/cache #4093

Closed
yamt opened this issue Jul 23, 2023 · 1 comment · Fixed by #4160
Closed

wasmer cache clean/dir doesn't seem to care .wasmer/cache #4093

yamt opened this issue Jul 23, 2023 · 1 comment · Fixed by #4160
Assignees
@theduke
Labels
🕵️ needs investigation The issue/PR needs further investigation priority-medium Medium priority issue
Milestone
backlog

Comments

@yamt
Copy link

yamt commented Jul 23, 2023

Describe the bug

wasmer cache clean and wasmer cache dir don't seem aware of .wasmer/cache

spacetanuki% wasmer --version
wasmer 4.0.0
spacetanuki% wasmer cache dir
/var/folders/74/hw1sphgx0lv63q6pq_n5grw00000gn/T/wasmer/4.0.0
spacetanuki% 
spacetanuki% find .wasmer/cache 
.wasmer/cache
.wasmer/cache/queries
.wasmer/cache/queries/version
.wasmer/cache/compiled
.wasmer/cache/compiled/engine-cranelift-v4
.wasmer/cache/compiled/engine-cranelift-v4/9D045073C496CCA32285A3AAAB95E9B90EE0DE36AEF62648AA3B85B432171FBC.bin
spacetanuki%

Steps to reproduce

Expected behavior

wasmer cache clean cleans .wasmer/cache

Actual behavior

it doesn't.

Additional context

macOS, homebrew-installed binary.
yamt added a commit to yamt/toywasm that referenced this issue Jul 23, 2023
@yamt
clean cache for wasmer 4.0.0
a09d2d9 
cf. wasmerio/wasmer#4093
yamt added a commit to yamt/toywasm that referenced this issue Jul 23, 2023
@yamt
clean cache for wasmer 4.0.0
4634ad6 
cf. wasmerio/wasmer#4093
@ptitSeb ptitSeb added the priority-medium Medium priority issue label Jul 25, 2023
@ptitSeb ptitSeb added this to the v4.2 milestone Jul 25, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented Jul 25, 2023

Also need to clean other type of cache (and older cache)

@ptitSeb ptitSeb added the 🕵️ needs investigation The issue/PR needs further investigation label Jul 25, 2023
Michael-F-Bryan pushed a commit that referenced this issue Aug 17, 2023
fix: Make the "wasmer cache" command use the same cache directory as …
94fa59e 
…the rest of the CLI (fixes #4093)
@Michael-F-Bryan Michael-F-Bryan mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

Labels
🕵️ needs investigation The issue/PR needs further investigation priority-medium Medium priority issue
Projects
None yet
Milestone
backlog
3 participants
@theduke @yamt @ptitSeb