Browser cfg, smaller WASM and HTTPS redirect #4112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
john-sharratt
commented
Jul 27, 2023
john-sharratt
commented
- The initialization configuration is now stored in the init.js file
- The WASM binary has been reduced from 1.8MB to 1.1MB
- When going to the site on HTTP it will redirect you to HTTPS
john-sharratt
requested review from
syrusakbary,
theduke,
ptitSeb and
Michael-F-Bryan
ptitSeb
reviewed
Jul 27, 2023
| @@ -233,7 +233,7 @@ unsafe fn wasi_env_with_filesystem_inner( | |||
| let module = &module.as_ref()?.inner; | |||
| let imports = imports?; | |||
|
|
|||
| let (wasi_env, import_object, runtime) = prepare_webc_env( | |||
| let (wasi_env, import_object) = prepare_webc_env( | |||
There was a problem hiding this comment.
those changes are already part of master. You might need to rebase or merge from master.
|
Switching over to another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.