Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the web runtime into wasmer-wasix #4119

Closed
wants to merge 12 commits into from
Closed

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Aug 2, 2023

WARNING: Do not merge this PR!

This PR requires #4115 to be merged first. Once that is done, we can rebase and switch the target branch back to master.

@Michael-F-Bryan Michael-F-Bryan changed the base branch from master to browser-cfg-with-tun-tap August 2, 2023 07:17
@syrusakbary
Copy link
Member

This PR requires #4112 to be merged first

#4112 was superseded by #4115. Did you mean #4115 ?

Base automatically changed from browser-cfg-with-tun-tap to master August 10, 2023 10:46
@zees-dev
Copy link

zees-dev commented Sep 16, 2023

Would like to use web runtime when building WasiFunctionEnv - currently cannot seem to do so since the code panics in the build_init function:

let runtime = self.runtime.unwrap_or_else(|| {
    #[cfg(feature = "sys-thread")]
    {
        Arc::new(PluggableRuntime::new(Arc::new(crate::runtime::task_manager::tokio::TokioTaskManager::default())))
    }

    #[cfg(not(feature = "sys-thread"))]
    {
        panic!("this build does not support a default runtime - specify one with WasiEnvBuilder::runtime()");
    }
});

^ could we instantiate the WebRuntime here under the #[cfg(feature = "js")] flag?

@Michael-F-Bryan
Copy link
Contributor Author

This functionality has now been built into the @wasmer/sdk JavaScript package in the wasmerio/wasmer-js repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants