Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test for small Stack (for #3808) #3957

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Jun 6, 2023

Added a test for small Stack

for ticket #3808

Note that the test needed to use Singlepass compiler, as Cranelift would optimized the code (even at optimisation level "None")and remove all the unused local, and so avoiding the stack overflow.

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner June 6, 2023 08:33
@ptitSeb ptitSeb requested a review from theduke June 6, 2023 08:33
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@theduke theduke merged commit fe1b440 into master Jun 6, 2023
@theduke theduke deleted the test_add_small_stack_test branch June 6, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants