Skip to content

Commit

Permalink
Disable small_stack test on Windows, not sure stack frame protection …
Browse files Browse the repository at this point in the history
…is completly efficient there
  • Loading branch information
ptitSeb authored and theduke committed Jun 6, 2023
1 parent 2ec4158 commit fe1b440
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/api/src/sys/tunables.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ mod tests {
}

#[test]
#[cfg(feature = "singlepass")]
#[cfg(all(feature = "singlepass", not(target_os = "windows")))]
fn check_small_stack() -> Result<(), Box<dyn std::error::Error>> {
use crate::{imports, wat2wasm, Engine, Instance, Module, Store};
use wasmer_compiler_singlepass::Singlepass;
Expand All @@ -288,6 +288,7 @@ mod tests {
// and remove all the unused local, even at optimization level "None"
// But this test needs the huge amount of locals (1024 + a few)
// so that the small stack is overflown (stack is only 8K, 1024 i64 local = 8K)
// tWindows is disable as it seems Stack frame protection is not 100% efficient
let wasm_bytes = wat2wasm(
br#"(module
(func (;0;) (result i64)
Expand Down

0 comments on commit fe1b440

Please sign in to comment.