Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "wasmer run-unstable" to "wasmer run" #3924

Merged
merged 30 commits into from
Jun 1, 2023
+1,336 −2,027
Merged

Rename "wasmer run-unstable" to "wasmer run" #3924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1e54331
Rename "wasmer run-unstable" to "wasmer run"
May 29, 2023
7c4834f
Added "run-unstable" as an alias of "wasmer run" for backwards compat…
May 29, 2023
2b4e3be
Tweaked the snapshot logging flag
May 29, 2023
464bcd4
The stderr in snapshot tests shouldn't contain log messages
May 29, 2023
d9df1c1
Make "wasmer run-unstable" exit with a WASI exit code
May 29, 2023
2c161b6
Allow runners to set WASI capabilities (fixes the async threads snaps…
May 29, 2023
18620ac
Make the stack_size argument always present
May 29, 2023
eed8ac5
Update an assertion
May 30, 2023
23f2739
tests: Fix test assertion for new "run" output
theduke May 31, 2023
081c840
build: Add make commands for debug integration cli tests
theduke May 31, 2023
55f8e22
Improve --mapdir mounting
theduke May 31, 2023
1d06a2f
Don't preopen / when mapping directories
theduke May 31, 2023
63faa97
chore: Fix lint
theduke May 31, 2023
3ea6b86
Actually mount when mapping into /
theduke May 31, 2023
48ecff0
We should be canonicalizing with OS APIs directly because our vfs lay…
May 31, 2023
1e32e9c
Updated the test for filtering out log lines in snapshot test output
May 31, 2023
fe95c22
Switch the "wasmer run" integration tests over to the assert-cli crate
May 31, 2023
a6945d1
Clippy lints
May 31, 2023
d90049f
Make sure canonicalize_without_inode() can handle UNC paths
May 31, 2023
2c1d2c9
Add more context to wasi runner errors
May 31, 2023
27b440c
It doesn't make sense to --mapdir "." when running Python
May 31, 2023
47e7980
Deleted some dead code
May 31, 2023
26cd672
Fix the UNC logic in canoncialize_without_inode()
May 31, 2023
7711432
Remove a redundant #[ignore] on Windows
May 31, 2023
db7b2e4
Let's fix the UNC logic in mount_directory_entries() instead
May 31, 2023
d38dc60
Added a WasiEnvBuilder::run_with_store_async() method
Jun 1, 2023
a03df59
Switch runners and "wasmer run" over to WasiEnvBuilder::run_with_stor…
Jun 1, 2023
3e8ed24
Clippy found a bug!
Jun 1, 2023
f0cda84
Fixed a bug where we reuse the wrong store when resuming
Jun 1, 2023
4c93eca
Reverted changes to the Makefile
Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 3 additions & 7 deletions lib/cli/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ use crate::commands::CreateExe;
#[cfg(feature = "wast")]
use crate::commands::Wast;
use crate::commands::{
Add, Cache, Config, Init, Inspect, List, Login, Publish, Run, RunUnstable, SelfUpdate,
Validate, Whoami,
Add, Cache, Config, Init, Inspect, List, Login, Publish, Run, SelfUpdate, Validate, Whoami,
};
#[cfg(feature = "static-artifact-create")]
use crate::commands::{CreateObj, GenCHeader};
Expand Down Expand Up @@ -41,9 +40,6 @@ enum WasmerCLIOptions {
/// List all locally installed packages
List(List),

/// Run a WebAssembly file. Formats accepted: wasm, wat
Run(Run),

/// Login into a wapm.io-like registry
Login(Login),

Expand Down Expand Up @@ -163,7 +159,8 @@ enum WasmerCLIOptions {
Add(Add),

/// (unstable) Run a WebAssembly file or WEBC container.
RunUnstable(RunUnstable),
#[clap(alias = "run-unstable")]
Run(Run),

// DEPLOY commands
#[clap(subcommand)]
Expand Down Expand Up @@ -202,7 +199,6 @@ impl WasmerCLIOptions {
Self::Binfmt(binfmt) => binfmt.execute(),
Self::Whoami(whoami) => whoami.execute(),
Self::Add(install) => install.execute(),
Self::RunUnstable(run2) => run2.execute(),

// Deploy commands.
Self::App(apps) => apps.run(),
Expand Down
5 changes: 2 additions & 3 deletions lib/cli/src/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ mod list;
mod login;
mod publish;
mod run;
mod run_unstable;
mod self_update;
mod validate;
#[cfg(feature = "wast")]
Expand All @@ -34,8 +33,8 @@ pub use create_exe::*;
#[cfg(feature = "wast")]
pub use wast::*;
pub use {
add::*, cache::*, config::*, init::*, inspect::*, list::*, login::*, publish::*, run::*,
run_unstable::RunUnstable, self_update::*, validate::*, whoami::*,
add::*, cache::*, config::*, init::*, inspect::*, list::*, login::*, publish::*, run::Run,
self_update::*, validate::*, whoami::*,
};
#[cfg(feature = "static-artifact-create")]
pub use {create_obj::*, gen_c_header::*};
Loading