Switch FileSystemCache to use checked artifact deserialization #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2023
Michael-F-Bryan
approved these changes
May 12, 2023
theduke
force-pushed
the
cache-use-safe-module-deserialization
branch
from
1907011 to
8c3e817
Compare
We recently introduced safe artifact deserialization methods, which are a much saner default than the unsafe variants, and only have small performance overhead. The CLI was switched to the the new, safe deserialization, but the cache was not updated. This commit and switches the FileSystemCache implementation to use the checked deserialization variants. NOTE: The Cache::load method should also be made safe, but that is a breaking change.
theduke
force-pushed
the
cache-use-safe-module-deserialization
branch
from
8c3e817 to
f87d0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently introduced safe artifact deserialization methods, which are a
much saner default than the unsafe variants, and only have small performance
overhead.
The CLI was switched to the the new, safe deserialization,
but the cache was not updated.
This commit and switches the FileSystemCache implementation to use the
checked deserialization variants.
NOTE: The Cache::load method should also be made safe, but that is a
breaking change.