Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Cache::load to be safe #3857

Closed
theduke opened this issue May 12, 2023 · 1 comment
Closed

Change Cache::load to be safe #3857

theduke opened this issue May 12, 2023 · 1 comment
Assignees
@theduke
Labels
🚨 breaking change This Issue or PR involves a breaking change 🎉 enhancement New feature! priority-high High priority issue
Milestone
v4.0

Comments

@theduke
Copy link
Contributor

theduke commented May 12, 2023

Currently the Cache::load trait method is unsafe.

Since we recently introduced checked/safe artifact deserialization , which is a much saner default, we should also switch the method to be safe.

Users really wanting to use unsafe deserialization can do their own implementation.

NOTE: this is a breaking change.

See also #3856 and #3855 .

NOTE: this also relates to @Michael-F-Bryan work on new caching primitives.
@theduke theduke added 🎉 enhancement New feature! 🚨 breaking change This Issue or PR involves a breaking change labels May 12, 2023
@theduke theduke added this to the v4.0 milestone May 12, 2023
@theduke theduke self-assigned this May 12, 2023
@ptitSeb ptitSeb added the priority-high High priority issue label May 16, 2023
@ptitSeb ptitSeb closed this as completed May 17, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented May 17, 2023

Cache load is always unsafe (by nature)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

Labels
🚨 breaking change This Issue or PR involves a breaking change 🎉 enhancement New feature! priority-high High priority issue
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
2 participants
@theduke @ptitSeb