Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce suggested backends to the ones compiled into wasmer #382

Merged
merged 4 commits into from
Apr 22, 2019
Merged

reduce suggested backends to the ones compiled into wasmer #382

merged 4 commits into from
Apr 22, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

resolves #380

@MarkMcCaskey MarkMcCaskey added the 🎉 enhancement New feature! label Apr 22, 2019
@MarkMcCaskey MarkMcCaskey requested a review from xmclark April 22, 2019 23:04
lachlansneff
lachlansneff reviewed Apr 22, 2019
View reviewed changes
src/bin/wasmer.rs Outdated Show resolved Hide resolved
lachlansneff
lachlansneff approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@lachlansneff lachlansneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 22, 2019
@bors @MarkMcCaskey
Merge #382
baae2b3 
382: reduce suggested backends to the ones compiled into wasmer r=MarkMcCaskey a=MarkMcCaskey

resolves #380 

Co-authored-by: Mark McCaskey <[email protected]>
Co-authored-by: Mark McCaskey <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 22, 2019

Build succeeded

@bors bors bot merged commit e8b2660 into master Apr 22, 2019
@bors bors bot deleted the feature/improve-backend-error-message branch April 22, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlansneff lachlansneff lachlansneff approved these changes

@xmclark xmclark Awaiting requested review from xmclark

Assignees
No one assigned
Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backends that haven't been compiled in shouldn't be listed
2 participants
@MarkMcCaskey @lachlansneff