Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backends that haven't been compiled in shouldn't be listed #380

Closed
jedisct1 opened this issue Apr 22, 2019 · 1 comment · Fixed by #382
Closed

Backends that haven't been compiled in shouldn't be listed #380

jedisct1 opened this issue Apr 22, 2019 · 1 comment · Fixed by #382
Assignees
@MarkMcCaskey
Labels
🎉 enhancement New feature!

Comments

@jedisct1
Copy link

Backend::variants() currently returns a static set of backends.

Which is quite confusing. The wasmer run help command always prints:

OPTIONS:
        --backend <backend>                   [default: cranelift]  [possible values: singlepass, cranelift, llvm]

Even if neither singlepass nor llvm have been compiled in.
@jedisct1 jedisct1 added the 🎉 enhancement New feature! label Apr 22, 2019
@lachlansneff
Copy link
Contributor

Oh, good idea.

@MarkMcCaskey MarkMcCaskey self-assigned this Apr 22, 2019
@MarkMcCaskey MarkMcCaskey mentioned this issue Apr 22, 2019
Merged
bors bot added a commit that referenced this issue Apr 22, 2019
@bors @MarkMcCaskey
Merge #382
baae2b3 
382: reduce suggested backends to the ones compiled into wasmer r=MarkMcCaskey a=MarkMcCaskey

resolves #380 

Co-authored-by: Mark McCaskey <[email protected]>
Co-authored-by: Mark McCaskey <[email protected]>
@bors bors bot closed this as completed in #382 Apr 22, 2019
surban pushed a commit to rust-wasi-web/wwrr that referenced this issue Nov 9, 2024
Merge pull request wasmerio#380 from wasmerio/auto-build-markdown-ren…
2f95397 
…derer

Wire up `vite.config.js` to automatically compile the `markdown-renderer` crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkMcCaskey MarkMcCaskey

Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reduce suggested backends to the ones compiled into wasmer wasmerio/wasmer
3 participants
@jedisct1 @MarkMcCaskey @lachlansneff