Switch wasmer_vfs::host_fs tests over to using temp directories
#3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
changed the title
wasmer_vfs::host_fs tests over to using a temp directorywasmer_vfs::host_fs tests over to using temp directories
Merged
Michael-F-Bryan
force-pushed
the
vfs-tempdir
branch
from
f84803c to
4ef63b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests in
wasmer_vfs::host_fscurrently write to the test directory.This PR switches them over to using a
tempfile::TempDirbecause a) it's cleaner, and more importantly, b) it meanscargo watchwon't peg the CPU to 100% because running the tests updates files inside thesrc/folder, which in turn triggers a re-run ofcargo watch, which causes the crate to be recompiled and all the tests to start again.