Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc, threads are enabled by default now #3665

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Fix doc, threads are enabled by default now #3665

merged 3 commits into from
Mar 8, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Mar 8, 2023

This is to address ticket #3645

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner March 8, 2023 10:14
@ptitSeb ptitSeb requested a review from theduke March 8, 2023 10:14
theduke
theduke reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backwards compat suggestion.

lib/cli/src/common.rs Show resolved Hide resolved
@ptitSeb ptitSeb requested a review from theduke March 8, 2023 11:09
@ptitSeb ptitSeb enabled auto-merge (squash) March 8, 2023 12:02
@ptitSeb ptitSeb merged commit ed3895b into master Mar 8, 2023
@ptitSeb ptitSeb deleted the fix_doc_threads_enabled branch March 8, 2023 12:08
@ptitSeb ptitSeb mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitSeb @theduke