Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads are enabled by default, contradicting the documentation #3645

Closed
TethysSvensson opened this issue Mar 5, 2023 · 4 comments
Closed
Assignees
Labels
📚 documentation Do you like to read?
Milestone

Comments

@TethysSvensson
Copy link

Describe the bug

The documentation on Features for v3.1.1 says that threads are disabled by default, however that is not the case.

Steps to reproduce

The following code crashes:

assert_eq!(wasmer::Features::new().threads, false);

Expected behavior

That the documentation matches the behavior.

@syrusakbary
Copy link
Member

Good call. We need to fix this on the docs

@ptitSeb ptitSeb added the 📚 documentation Do you like to read? label Mar 7, 2023
@ptitSeb ptitSeb added this to the v3.2 milestone Mar 7, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented Mar 7, 2023

Need to check also the CLI to be able to disable threads.

@syrusakbary
Copy link
Member

@ptitSeb we should enable them by default now (replicating browsers behavior), so we just need to update the docs

@ptitSeb
Copy link
Contributor

ptitSeb commented Mar 8, 2023

Done with #3665

@ptitSeb ptitSeb closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Do you like to read?
Projects
None yet
Development

No branches or pull requests

4 participants