Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable (most) WASIX Snapshot Tests #3656

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Re-enable (most) WASIX Snapshot Tests #3656

merged 3 commits into from
Mar 7, 2023

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Mar 7, 2023 •
edited
Loading

  • tests: Re-enable some of the WASIX snapshot tests
  • chore: Fix build warning due to unused variable

Mostly fixes #3616

@theduke theduke requested a review from ptitSeb March 7, 2023 11:26
ptitSeb
ptitSeb approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Child exited with 5"?

@theduke theduke force-pushed the reenable-snapshot-tests branch from 5e130d6 to 553c916 Compare March 7, 2023 18:42
@theduke theduke merged commit f1459f3 into master Mar 7, 2023
@theduke theduke deleted the reenable-snapshot-tests branch March 7, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASIX: Fix and re-enable Snapshot Tests
2 participants
@theduke @ptitSeb