Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASIX: Fix and re-enable Snapshot Tests #3616

Closed
theduke opened this issue Feb 23, 2023 · 0 comments · Fixed by #3656
Closed

WASIX: Fix and re-enable Snapshot Tests #3616

theduke opened this issue Feb 23, 2023 · 0 comments · Fixed by #3656
Assignees
@theduke @ptitSeb
Labels
priority-medium Medium priority issue
Milestone
v3.2

Comments

@theduke
Copy link
Contributor

theduke commented Feb 23, 2023

During the merge of #3422 some of the snapshot tests located in tests/integration/cli/tests/snapshot.rs were either restricted to specific target architectures, or downright disabled.

Some of them because the tests are multi-threaded and produce in-deterministic output.

Others because of other determinism issues.

The tests must be re-evaluated, fixed up and re-enabled, or replaced with equivalent but more deterministc test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

@ptitSeb ptitSeb

Labels
priority-medium Medium priority issue
Projects
None yet
Milestone
v3.2
Development

Successfully merging a pull request may close this issue.

Re-enable (most) WASIX Snapshot Tests wasmerio/wasmer
2 participants
@theduke @ptitSeb