Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create exe tests #3487

Closed
wants to merge 7 commits into from
Closed

Fix create exe tests #3487

wants to merge 7 commits into from

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Jan 17, 2023

Fixes #3481.

@fschutt fschutt requested a review from syrusakbary as a code owner January 17, 2023 17:46
@fschutt fschutt requested a review from theduke January 17, 2023 18:08
theduke
theduke requested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fschutt why were the clippy issues not caught on CI before the CI refactor merge?

lib/compiler-llvm/src/abi/aarch64_systemv.rs Show resolved Hide resolved
lib/compiler-llvm/src/abi/x86_64_systemv.rs Show resolved Hide resolved
lib/compiler-llvm/src/translator/code.rs Outdated Show resolved Hide resolved
@fschutt
Copy link
Contributor Author

fschutt commented Jan 18, 2023

@fschutt why were the clippy issues not caught on CI before the CI refactor merge?

Yes, this is something we need to sync on. For some reason I always see a green master, then I make my changes and then suddenly make lint complains and is full of bugs, which makes subsequent PRs harder (I did not expect make lint to fail).

For some reason the CI doesn't properly catch make lint failures, I opened #3489 to track this.

@fschutt fschutt enabled auto-merge January 18, 2023 14:45
@fschutt fschutt mentioned this pull request Jan 18, 2023
Merged
@fschutt
Copy link
Contributor Author

fschutt commented Jan 18, 2023

Done in #3496.

@fschutt fschutt closed this Jan 18, 2023
auto-merge was automatically disabled January 18, 2023 20:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke requested changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create-exe with Serialized object fail
3 participants
@fschutt @syrusakbary @theduke