Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make lint does not properly catch CI failures when committing changes into master #3489

Closed
fschutt opened this issue Jan 18, 2023 · 1 comment
Closed

make lint does not properly catch CI failures when committing changes into master #3489

fschutt opened this issue Jan 18, 2023 · 1 comment

Comments

@fschutt
Copy link
Contributor

fschutt commented Jan 18, 2023

For some reason we can have a green master, but when I make changes off of that I suddenly get lots of "make lint" errors that I have to then fix in the next PR, which makes those PRs harder to review. We need to debug why this happens and fix it.
This was referenced Jan 18, 2023
Closed
Closed
Closed
@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 24, 2023

Suspecting this was an issue with a different version of clippy localy, bringing in new warning and error not found on CI.
Closing this one.

@ptitSeb ptitSeb closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ptitSeb @fschutt