Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Create-exe with serialize test, something is wrong with the generated exe #3480

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Ignore Create-exe with serialize test, something is wrong with the generated exe #3480

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90683e4
[TEST] Ignore Create-exe with serialize test, something is wrong with…
ptitSeb Jan 16, 2023
1016239
Added TODO comment on newly ignored tests
ptitSeb Jan 16, 2023
5c4e388
Changed expected message for test run_wasi_works_non_existent
ptitSeb Jan 16, 2023
6c8b1fd
Added reference to ticket #3481 on the disabled tests
ptitSeb Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/integration/cli/tests/create_exe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,8 @@ fn create_exe_works_with_file() -> anyhow::Result<()> {

// Ignored because of -lunwind linker issue on Windows
// see https://github.com/wasmerio/wasmer/issues/3459
#[cfg_attr(target_os = "windows", ignore)]
ptitSeb marked this conversation as resolved.
Show resolved Hide resolved
//#[cfg_attr(target_os = "windows", ignore)]
#[ignore]
#[test]
fn create_exe_serialized_works() -> anyhow::Result<()> {
let temp_dir = tempfile::tempdir()?;
Expand Down Expand Up @@ -683,7 +684,8 @@ fn create_exe_with_object_input_symbols() -> anyhow::Result<()> {

// Ignored because of -lunwind linker issue on Windows
// see https://github.com/wasmerio/wasmer/issues/3459
#[cfg_attr(target_os = "windows", ignore)]
//#[cfg_attr(target_os = "windows", ignore)]
#[ignore]
#[test]
fn create_exe_with_object_input_serialized() -> anyhow::Result<()> {
create_exe_with_object_input(vec![
Expand Down