Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Create-exe with serialize test, something is wrong with the generated exe #3480

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Jan 16, 2023

Ignore Create-exe with serialize test, something is wrong with the generated exe the generated exe and needs further investigation.
But to not hold other more priority work, the tests are for now disabled to help the CI goes green again.

… the generated exe and needs further investigation
@ptitSeb ptitSeb requested review from theduke and fschutt January 16, 2023 16:16
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to create the issue and reference the PR, but otherwise 👍

@theduke theduke removed the request for review from fschutt January 16, 2023 17:01
@ptitSeb ptitSeb enabled auto-merge January 16, 2023 17:47
@ptitSeb ptitSeb merged commit 6b57568 into master Jan 16, 2023
@ptitSeb ptitSeb deleted the fix_ci_ignore_create_exe_with_serialized branch January 16, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants