Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assert in sse_round_fn and handle case where src2 is in memory #3465

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Remove assert in sse_round_fn and handle case where src2 is in memory #3465

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba10624
Remove assert in sse_round_fn and handle case where src2 is in memory
Jan 10, 2023
2d05574
Add if else
Jan 10, 2023
bfa1b67
Rework fix when x != dst
Jan 10, 2023
3f4e629
Merge branch 'master' into singlepass_fix_sse42_backend_sse_round
theduke Jan 16, 2023
f9b6bc4
Merge branch 'master' into singlepass_fix_sse42_backend_sse_round
theduke Jan 16, 2023
8481a84
Merge branch 'master' into singlepass_fix_sse42_backend_sse_round
syrusakbary Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/compiler-singlepass/src/emitter_x64.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,11 +909,14 @@ macro_rules! sse_round_fn {
|emitter: &mut AssemblerX64, precision: Precision, src1: XMM, src2: XMMOrMemory, dst: XMM| {
match src2 {
XMMOrMemory::XMM(x) => {
assert_eq!(src1, x);
move_src_to_dst(emitter, precision, src1, dst);
dynasm!(emitter ; $ins Rx((dst as u8)), Rx((dst as u8)), $mode)
if x != dst {
move_src_to_dst(emitter, precision, src1, dst);
}
dynasm!(emitter ; $ins Rx((x as u8)), Rx((dst as u8)), $mode)
}
XMMOrMemory::Memory(..) => unreachable!(),
XMMOrMemory::Memory(base, disp) => {
dynasm!(emitter ; $ins Rx((dst as u8)), [Rq((base as u8)) + disp], $mode)
},
}
}
}
Expand Down