-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove assert in sse_round_fn and handle case where src2 is in memory #3465
Remove assert in sse_round_fn and handle case where src2 is in memory #3465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a if
/ else
branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I reviewed the ROUNDSS/VROUNDSS opcode (for example, it's one of the opcode use here): https://www.felixcloutier.com/x86/roundss
And it's not what I imagined.
So the code should be:
if x != dst {
move_src_to_dst(emitter, precision, src1, dst);
}
dynasm!(emitter ; $ins Rx((x as u8)), Rx((dst as u8)), $mode)
Basicaly a bigger change, but that version should be exact. It's not important for now, as ROUND functions are basically used as 2 operators opcode, never as 3-way in Singlepass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should already be approved. But approving again to see if that trigger tests
eaab3cc
to
675cf17
Compare
675cf17
to
bfa1b67
Compare
Merged manually, as I had no idea why tests are not being executed (we will revert in case tests fail) |
@syrusakbary Github Actions have been problematic the last two days, also on other repos. |
In Singlepass SSE4.2 backend and for sse_round_fn function, some special cases were not handled:
This should fix those cases.
This is a follow up of ticket #3461