Fix wasmer run not interpreting URLs correctly + display fixes #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschutt
changed the title
Michael-F-Bryan
suggested changes
Nov 24, 2022
1 task
Michael-F-Bryan
approved these changes
Nov 24, 2022
syrusakbary
reviewed
Nov 24, 2022
syrusakbary
reviewed
Nov 24, 2022
syrusakbary
reviewed
Nov 24, 2022
syrusakbary
reviewed
Nov 24, 2022
syrusakbary
reviewed
Nov 24, 2022
syrusakbary
reviewed
Nov 24, 2022
syrusakbary
approved these changes
Nov 24, 2022
syrusakbary
reviewed
Nov 25, 2022
tests/integration/cli/tests/run.rs
Outdated
| } | ||
|
|
||
| fn test_no_imports_wat_path() -> String { | ||
| format!("{}/{}", ASSET_PATH, "fib.wat") | ||
| let slash = if ASSET_PATH.ends_with('/') { "" } else { "/" }; |
There was a problem hiding this comment.
This is not the correct way of joining paths. We should use the std os path join and return a Path
syrusakbary
reviewed
Nov 25, 2022
syrusakbary
approved these changes
Nov 25, 2022
|
bors r+ |
|
Merging manually as tests should pass |
bors bot
added a commit
that referenced
this pull request
Nov 25, 2022
3370: Fix wasmer run not interpreting URLs correctly + display fixes r=fschutt a=fschutt Fixes #3366. Fixes #3346. Should land in the 3.0.2 release. Co-authored-by: Felix Schütt <[email protected]> Co-authored-by: Felix Schütt <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3366.
Fixes #3346.
Should land in the 3.0.2 release.