Fix installing wasmer via cargo-binstall #3369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
Merged
|
There were some network outages on wapm.dev which is why this PR didn't pass immediately. I reopened + followed up on this in #3371 (it's easier to merge that way). Thank you for your contribution! |
bors bot
added a commit
that referenced
this pull request
Nov 24, 2022
3371: Fix cargo binstall r=fschutt a=fschutt This PR is a continuation of #3369 because for some unexpected reason wasmer login failed, so it's easier for me to debug the CI failure. Co-authored-by: Jiahao XU <[email protected]> Co-authored-by: Felix Schütt <[email protected]> Co-authored-by: Felix Schütt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiahao XU [email protected]
Description
With wasmer v3.0.1, the link to release artifacts changed a little bit which breaks installing wasmer via cargo-binstall.
Also the instruction for installing wasmer via cargo-binstall in README.md is wrong.
Review