Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat riscv llvm and cranelift #3244

Merged
merged 25 commits into from
Mar 22, 2023
Merged

Feat riscv llvm and cranelift #3244

merged 25 commits into from
Mar 22, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Oct 20, 2022

Description

  • Add RISC-V support for the LLVM compiler
  • Add RISC-V support for Cranelift compiler
  • Update rust toolchain to 1.65

Some tests have been disabled specificaly for RISCV. Thoses tests will need to be debug later.

The migration to 1.65 implied removing the [profile.dev] profile from main Cargo.toml. It contained only split-debuginfo=unpacked that is unsupported on Windows and just fail the build. The split-debug info will be default value now (so "off" on Linux, and "packed" on Windows and MacOS). If it's an issue, it can be forced by setting env. var., like CARGO_PROFILE_DEV_SPLIT_DEBUGINFO=packed in Makefile or CI Actions.

@syrusakbary
Copy link
Member

syrusakbary commented Oct 21, 2022

Cranelift recently added also support for RISC-V, it might be interesting to also enable and test it @ptitSeb
bytecodealliance/wasmtime#4271 bytecodealliance/wasmtime#5044

@ptitSeb
Copy link
Contributor Author

ptitSeb commented Oct 21, 2022

Cranelift recently added also support for RISC-V, it might be interesting to also enable and test it @ptitSeb bytecodealliance/wasmtime#4271 bytecodealliance/wasmtime#5044

Yes, I have seen that, but I think I'll separate it from this ticket and create 2 more tickets: 1. update cranelift 2. add riscv support

@ptitSeb ptitSeb marked this pull request as ready for review March 17, 2023 12:56
@ptitSeb ptitSeb requested a review from syrusakbary as a code owner March 17, 2023 12:56
@ptitSeb ptitSeb changed the title Feat riscv llvm Feat riscv llvm and cranelift Mar 17, 2023
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my suggestions, the PR looks good

Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RISC-V here we come, landing this will be awesome!

Just a few nitpicks.

Regarding the large error: the error is not in any hot path, so the large error should be fine, just having the annotation everywhere is pretty annoying.

Because users will also get this error if they use clippy, not just us.

deny.toml Outdated Show resolved Hide resolved
lib/compiler-llvm/src/config.rs Show resolved Hide resolved
tests/ignores.txt Show resolved Hide resolved
lib/wasi/src/lib.rs Show resolved Hide resolved
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RISC-V here we come.

@ptitSeb ptitSeb merged commit 7500ce7 into master Mar 22, 2023
@ptitSeb ptitSeb deleted the feat_riscv_llvm branch March 22, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants