-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat riscv llvm and cranelift #3244
Conversation
6b4bcc5
to
0ccc9ce
Compare
36304e4
to
22944a1
Compare
Cranelift recently added also support for RISC-V, it might be interesting to also enable and test it @ptitSeb |
Yes, I have seen that, but I think I'll separate it from this ticket and create 2 more tickets: 1. update cranelift 2. add riscv support |
…aks Windows). split-debug info is now the default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my suggestions, the PR looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RISC-V here we come, landing this will be awesome!
Just a few nitpicks.
Regarding the large error: the error is not in any hot path, so the large error should be fine, just having the annotation everywhere is pretty annoying.
Because users will also get this error if they use clippy, not just us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RISC-V here we come.
Description
Some tests have been disabled specificaly for RISCV. Thoses tests will need to be debug later.
The migration to 1.65 implied removing the
[profile.dev]
profile from mainCargo.toml
. It contained onlysplit-debuginfo=unpacked
that is unsupported on Windows and just fail the build. The split-debug info will be default value now (so "off" on Linux, and "packed" on Windows and MacOS). If it's an issue, it can be forced by setting env. var., likeCARGO_PROFILE_DEV_SPLIT_DEBUGINFO=packed
in Makefile or CI Actions.