cranelift: Native feature detection for RISC-V #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonso360
force-pushed
the
riscv-feature-detect
branch
from
0e81662 to
858dff9
Compare
github-actions
bot
added
the
cranelift
cfallin
reviewed
Oct 11, 2022
Thanks @cfallin
cfallin
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR enables native feature detection for RISC-V. We use the same mechanisms as S390X namely HW_CAP to query extensions. This also changes the testrunner to run tests based on capabilities instead of assuming they'll be there.
Not all extensions are supported by this method, so we ignore those. Fortunately none of them seem to be used by tests in our test suite.
cc: @yuyang-ok @cfallin