wasmer-cli: create-obj command #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Aug 1, 2022
syrusakbary
reviewed
Aug 1, 2022
syrusakbary
reviewed
Aug 1, 2022
lib/compiler/src/engine/artifact.rs
Outdated
Comment on lines
45
to
48
| /// FIXME | ||
| Universal(UniversalArtifact), | ||
| /// FIXME | ||
| Static(StaticArtifact), |
There was a problem hiding this comment.
I don't think this is the optimal way of doing this. Basically both of them shared the finished functions, signatures and so on.
The only different thing is frame_info_registration and _symbol_registry. But that's only needed when using loading the artifact. In case of frame_info_registration is already optional, and perhaps we can make _symbol_registry is only needed at loading time (not really needed to store it)
There was a problem hiding this comment.
No it isn't the optimal way, but it was the fastest way to get it working, next step is making it prettier as you say
…-artifact-load`,`static-artifact-create` feature flags
epilys
force-pushed
the
create-obj
branch
2 times, most recently
from
3085ae9 to
16465ee
Compare
epilys
changed the title
syrusakbary
approved these changes
Aug 2, 2022
|
Once lint is fixed we should be good to merge |
lib/compiler: read static object
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.