Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Artifact type from enum to struct #3063

Closed
epilys opened this issue Aug 2, 2022 · 0 comments · Fixed by #3118
Closed

Refactor Artifact type from enum to struct #3063

epilys opened this issue Aug 2, 2022 · 0 comments · Fixed by #3118
Assignees
@epilys
Labels
create-exe priority-high High priority issue
Milestone
v3.0

Comments

@epilys
Copy link
Contributor

epilys commented Aug 2, 2022

PR #3057 changes the Artifact type to an enum in order to work with staticlib-like artifacts. This is not optimal since the two enum variants share most of their fields and can be unified back into a struct.
@epilys epilys added the priority-high High priority issue label Aug 2, 2022
@epilys epilys added this to the v3.0 milestone Aug 2, 2022
@epilys epilys self-assigned this Aug 2, 2022
epilys added a commit that referenced this issue Aug 18, 2022
@epilys
Refactor Artifact enum into a struct
f8ddcbf 
Closes #3063

Refactor Artifact type from enum to struct #3063 #3063
@epilys epilys mentioned this issue Aug 18, 2022
Merged
epilys added a commit that referenced this issue Aug 18, 2022
@epilys
Refactor Artifact enum into a struct
6b11456 
Closes #3063

Refactor Artifact type from enum to struct #3063 #3063
bors bot added a commit that referenced this issue Aug 18, 2022
@bors @epilys
Merge #3118
1a37e61 
3118: Refactor Artifact enum into a struct r=epilys a=epilys

Closes #3063

Refactor Artifact type from enum to struct #3063 #3063

Co-authored-by: Manos Pitsidianakis <[email protected]>
bors bot added a commit that referenced this issue Aug 18, 2022
@bors @epilys
Merge #3118
b801e45 
3118: Refactor Artifact enum into a struct r=epilys a=epilys

Closes #3063

Refactor Artifact type from enum to struct #3063 #3063

Co-authored-by: Manos Pitsidianakis <[email protected]>
@bors bors bot closed this as completed in 1756456 Aug 18, 2022
ptitSeb pushed a commit that referenced this issue Oct 20, 2022
@epilys @ptitSeb
Refactor Artifact enum into a struct
129e203 
Closes #3063

Refactor Artifact type from enum to struct #3063 #3063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epilys epilys

Labels
create-exe priority-high High priority issue
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Refactor Artifact enum into a struct wasmerio/wasmer
2 participants
@syrusakbary @epilys