Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved EngineBuilder API #3047

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Improved EngineBuilder API #3047

merged 1 commit into from
Jul 28, 2022

Conversation

syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Jul 28, 2022 •
edited
Loading

This PR is a followup from #3046.

It basically allows Store being created from anything that can get into Into<Engine>, which simplifies greatly the API.
It also improves the EngineBuilder API, by simplify the ::new method and making the modifier chain usable when doing set_target, set_features.

The PR also deprecates Store::new_with_engine in favor of Store::new since Store::new can now take EngineBuilder, Engine and Box<dyn CompilerConfig>.

@syrusakbary syrusakbary force-pushed the engine-api-improvement branch from f2ec550 to 19729c5 Compare July 28, 2022 04:26
@epilys epilys force-pushed the engine-api-improvement branch 2 times, most recently from 1913548 to b773fe9 Compare July 28, 2022 10:00
@syrusakbary @epilys
Improved EngineBuilder and Store API
4384ddf 
- Store::new() now takes an impl Into<Engine>.
- Added Into<Engine> impls in each of the compilers
- Updated docs/migration_to_3.0.0.md on API usage
@epilys epilys force-pushed the engine-api-improvement branch from b773fe9 to 4384ddf Compare July 28, 2022 12:20
@epilys
Copy link
Contributor

epilys commented Jul 28, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 28, 2022

Build succeeded:

@bors bors bot merged commit 5e26bc4 into master Jul 28, 2022
@bors bors bot deleted the engine-api-improvement branch July 28, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epilys epilys epilys approved these changes

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syrusakbary @epilys @ptitSeb