Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Backend into EngineBuilder and refactor feature flags #3046

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Merge Backend into EngineBuilder and refactor feature flags #3046

merged 1 commit into from
Jul 27, 2022

Conversation

epilys
Copy link
Contributor

@epilys epilys commented Jul 27, 2022

No description provided.

@epilys epilys added this to the v3.0 milestone Jul 27, 2022
@epilys epilys self-assigned this Jul 27, 2022
@epilys epilys requested a review from syrusakbary as a code owner July 27, 2022 13:10
@epilys epilys force-pushed the engine-refactor branch from fb7a883 to 3ac7c60 Compare July 27, 2022 16:44
@epilys epilys force-pushed the engine-refactor branch from 3ac7c60 to 214346a Compare July 27, 2022 18:04
@epilys
Copy link
Contributor Author

epilys commented Jul 27, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 27, 2022

Build succeeded:

@bors bors bot merged commit b2dc07e into master Jul 27, 2022
@bors bors bot deleted the engine-refactor branch July 27, 2022 19:32
@syrusakbary syrusakbary mentioned this pull request Jul 28, 2022
Merged
bors bot added a commit that referenced this pull request Jul 28, 2022
@bors @syrusakbary
Merge #3047
5e26bc4 
3047: Improved EngineBuilder API r=epilys a=syrusakbary

This PR is a followup from #3046.

It basically allows Store being created from anything that can get into `Into<Engine>`, which simplifies greatly the API.
It also improves the `EngineBuilder` API, by simplify the `::new` method and making the modifier chain usable when doing `set_target`, `set_features`.

The PR also deprecates `Store::new_with_engine` in favor of `Store::new` since `Store::new` can now take `EngineBuilder`, `Engine` and `Box<dyn CompilerConfig>`.

Co-authored-by: Syrus Akbary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees

@epilys epilys

Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@epilys