Remove Engine, Artifact traits, merge all Engines into one, make everything rkyv serialazable #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epilys
force-pushed
the
wasmer3-rkyv-archives
branch
from
ccfa86d to
ec375b1
Compare
syrusakbary
reviewed
Jul 20, 2022
syrusakbary
reviewed
Jul 20, 2022
epilys
force-pushed
the
wasmer3-rkyv-archives
branch
from
ec375b1 to
d9d36af
Compare
This was
linked to
issues
Jul 21, 2022
syrusakbary
reviewed
Jul 21, 2022
syrusakbary
reviewed
Jul 21, 2022
syrusakbary
reviewed
Jul 21, 2022
syrusakbary
approved these changes
Jul 21, 2022
epilys
force-pushed
the
wasmer3-rkyv-archives
branch
from
8264aec to
bdb0c8c
Compare
rkyv is only needed in wasmer-types crate after moving all serializable types there.
Instead of accessing Arc<ModuleInfo> from the artifact a module was instantiated from, create a copy from it in each instantiated module.
In favor of using UniversalArtifact everywhere
The Universal type was essentially a builder of engines that's given a compiler backend and creates an Engine with .engine() method. The name was not clear.
epilys
force-pushed
the
wasmer3-rkyv-archives
branch
from
bdb0c8c to
7a024be
Compare
epilys
force-pushed
the
wasmer3-rkyv-archives
branch
from
7a024be to
924d2dc
Compare
|
We need to test #2895 as part of this PR |
syrusakbary
reviewed
Jul 25, 2022
| @@ -20,9 +20,9 @@ | |||
|
|
|||
| use std::str::FromStr; | |||
| use wasmer::{wat2wasm, Module, RuntimeError, Store}; | |||
| use wasmer_compiler::Universal; | |||
| use wasmer_compiler::{CpuFeature, Target, Triple}; | |||
| use wasmer_compiler::Backend; | |||
syrusakbary
reviewed
Jul 25, 2022
| /// Finishes the instantiation of a just created `InstanceHandle`. | ||
| /// | ||
| /// # Safety | ||
| /// | ||
| /// See [`InstanceHandle::finish_instantiation`]. | ||
| unsafe fn finish_instantiation( | ||
| pub unsafe fn finish_instantiation( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
Review
Bugs
make build-capi-headless-universaldoesn't compile anymore because the feature combinations have gotten a bit complex.