Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Module::artifact #2637

Closed
syrusakbary opened this issue Oct 28, 2021 · 1 comment · Fixed by #3029
Closed

Remove Module::artifact #2637

syrusakbary opened this issue Oct 28, 2021 · 1 comment · Fixed by #3029
Assignees
@ptitSeb
Labels
bug Something isn't working priority-medium Medium priority issue
Milestone
v3.0

Comments

@syrusakbary
Copy link
Member

syrusakbary commented Oct 28, 2021 •
edited
Loading

Describe the bug

Remove Module::artifact method since it is too dangerous (see #1943 for more
details). This method has initially been introduced as a hack

This should be done after #2916
@syrusakbary syrusakbary added the bug Something isn't working label Oct 28, 2021
@syrusakbary syrusakbary mentioned this issue Oct 28, 2021
Closed
1 task
@Amanieu Amanieu added the priority-medium Medium priority issue label Feb 23, 2022
@Amanieu Amanieu added this to the v3.0 milestone Feb 23, 2022
@ptitSeb ptitSeb self-assigned this May 9, 2022
ptitSeb added a commit that referenced this issue May 9, 2022
@ptitSeb
Removed Module::Artifact (for #2637)
f7ce4e5
@ptitSeb ptitSeb mentioned this issue May 9, 2022
Closed
epilys added a commit that referenced this issue Jul 21, 2022
@epilys
Remove Module::artifact()
7c35aa5 
Closes #2637
@epilys epilys linked a pull request Jul 21, 2022 that will close this issue
Remove Engine, Artifact traits, merge all Engines into one, make everything rkyv serialazable #3029
Merged
2 tasks
epilys added a commit that referenced this issue Jul 25, 2022
@epilys
Remove Module::artifact()
b9ab951 
Closes #2637
@syrusakbary
Copy link
Member Author

This is fixed in #3029

ptitSeb pushed a commit that referenced this issue Oct 20, 2022
@epilys @ptitSeb
Remove Module::artifact()
52d0b6c 
Closes #2637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptitSeb ptitSeb

Labels
bug Something isn't working priority-medium Medium priority issue
Projects
None yet
Milestone
v3.0
3 participants
@syrusakbary @Amanieu @ptitSeb