Remove cranelift from sys-default feature #3004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschutt
force-pushed
the
remove-cranelift-default
branch
from
499fca6 to
9b5bcda
Compare
epilys
suggested changes
Jul 5, 2022
fschutt
force-pushed
the
remove-cranelift-default
branch
from
1c32873 to
eb12cef
Compare
fschutt
force-pushed
the
remove-cranelift-default
branch
3 times, most recently
from
4a86f5d to
a43803f
Compare
fschutt
force-pushed
the
remove-cranelift-default
branch
from
a43803f to
7303b82
Compare
syrusakbary
reviewed
Jul 6, 2022
lib/wasi/Cargo.toml
Outdated
Comment on lines
55
to
57
| compiler-singlepass = ["wasmer/default-singlepass"] | ||
| compiler-cranelift = ["wasmer/default-cranelift"] | ||
| compiler-llvm = ["wasmer/default-llvm"] |
syrusakbary
reviewed
Jul 6, 2022
Makefile
Outdated
| @@ -486,10 +486,10 @@ test-packages: | |||
| test-js: test-js-api test-js-wasi | |||
|
|
|||
| test-js-api: | |||
| cd lib/api && wasm-pack test --node -- --no-default-features --features js-default,wat | |||
| cd lib/api && wasm-pack test --node -- --no-default-features --features js-default,wat,default-compiler | |||
There was a problem hiding this comment.
No compiler shall be included here I believe
syrusakbary
reviewed
Jul 6, 2022
Makefile
Outdated
|
|
||
| test-js-wasi: | ||
| cd lib/wasi && wasm-pack test --node -- --no-default-features --features test-js | ||
| cd lib/wasi && wasm-pack test --node -- --no-default-features --features test-js,default-compiler |
There was a problem hiding this comment.
No compiler shall be included here I believe
syrusakbary
reviewed
Jul 6, 2022
lib/wasi/Cargo.toml
Outdated
| @@ -46,12 +46,16 @@ wasm-bindgen-test = "0.3.0" | |||
| tracing-wasm = "0.2" | |||
|
|
|||
| [features] | |||
| default = ["sys-default"] | |||
| default = ["wasmer/sys", "wasmer/wat", "wasmer/default-engine", "sys", "logging", "host-fs", "sys-poll", "host-vnet"] | |||
There was a problem hiding this comment.
Those are parts already of sys-default. It's way better to keep using those
syrusakbary
reviewed
Jul 6, 2022
tests/lib/wast/Cargo.toml
Outdated
Comment on lines
15
to
16
| wasmer = { path = "../../../lib/api", version = "=2.3.0", default-features = false, features = ["experimental-reference-types-extern-ref"] } | ||
| wasmer-wasi = { path = "../../../lib/wasi", version = "=2.3.0" } | ||
| wasmer-wasi = { path = "../../../lib/wasi", version = "=2.3.0", features = ["compiler-cranelift"] } |
There was a problem hiding this comment.
I think we can just have:
Suggested change
| wasmer = { path = "../../../lib/api", version = "=2.3.0", default-features = false, features = ["experimental-reference-types-extern-ref"] } | |
| wasmer-wasi = { path = "../../../lib/wasi", version = "=2.3.0" } | |
| wasmer-wasi = { path = "../../../lib/wasi", version = "=2.3.0", features = ["compiler-cranelift"] } | |
| wasmer = { path = "../../../lib/api", version = "=2.3.0", default-features = false, features = ["experimental-reference-types-extern-ref", "cranelift"] } | |
| wasmer-wasi = { path = "../../../lib/wasi", version = "=2.3.0" } |
When using the Wasmer-WASI crate, the sys-default feature from wasmer is depending upon, which causes the following to conflict: [dependencies.wasmer] version = "2.0" default-features=false features=["sys" , "compiler-singlepass", "engine-universal"] [dependencies.wasmer-wasi] version = "2.0" Because wasmer-wasi "2.0" depends on wasmer with the default features, which implies using cranelift, which conflicts with singlepass. Fixes #2882
fschutt
force-pushed
the
remove-cranelift-default
branch
from
7303b82 to
49551d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Wasmer-WASI crate, the sys-default feature from wasmer is depending upon, which causes the following to conflict:
Because wasmer-wasi "2.0" depends on wasmer with the default features, which implies using cranelift, which conflicts with singlepass.
Fixes #2882
Review