Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasmer-WASI depends on Cranelift by default #2882

Closed
syrusakbary opened this issue May 13, 2022 · 0 comments · Fixed by #3030
Closed

Wasmer-WASI depends on Cranelift by default #2882

syrusakbary opened this issue May 13, 2022 · 0 comments · Fixed by #3030
Assignees
@fschutt
Labels
bug Something isn't working 🍋 Low-hanging Fruit priority-low Low priority issue priority-medium Medium priority issue
Milestone
v3.0

Comments

@syrusakbary
Copy link
Member

When using the Wasmer-WASI crate, the sys-default feature from wasmer is depending upon, which causes the following to conflict

wasmer = { version = "2.0", default-features=false,  features=["sys" , "compiler-singlepass", "engine-universal"] }
wasmer-wasi = "2.0"

(because wasmer-wasi "2.0" depends on wasmer with the default features, which implies using cranelift, which conflicts with singlepass)
@syrusakbary syrusakbary added the bug Something isn't working label May 13, 2022
@epilys epilys added the priority-medium Medium priority issue label May 18, 2022
@epilys epilys self-assigned this May 18, 2022
@epilys epilys added this to the v2.x milestone May 18, 2022
@epilys epilys modified the milestones: v2.x, v3.0 Jun 21, 2022
@fschutt fschutt assigned fschutt and unassigned epilys Jul 4, 2022
fschutt added a commit that referenced this issue Jul 4, 2022
@fschutt
Remove cranelift from sys-default feature
499fca6 
When using the Wasmer-WASI crate, the sys-default feature from 
wasmer is depending upon, which causes the following to conflict:

[dependencies.wasmer]
version = "2.0"
default-features=false
features=["sys" , "compiler-singlepass", "engine-universal"]

[dependencies.wasmer-wasi]
version = "2.0"

Because wasmer-wasi "2.0" depends on wasmer with the default features, 
which implies using cranelift, which conflicts with singlepass.

Fixes #2882
@fschutt fschutt mentioned this issue Jul 4, 2022
Closed
1 task
fschutt added a commit that referenced this issue Jul 5, 2022
@fschutt
Remove cranelift from sys-default feature
9b5bcda 
When using the Wasmer-WASI crate, the sys-default feature from
wasmer is depending upon, which causes the following to conflict:

[dependencies.wasmer]
version = "2.0"
default-features=false
features=["sys" , "compiler-singlepass", "engine-universal"]

[dependencies.wasmer-wasi]
version = "2.0"

Because wasmer-wasi "2.0" depends on wasmer with the default features,
which implies using cranelift, which conflicts with singlepass.

Fixes #2882
fschutt added a commit that referenced this issue Jul 5, 2022
@fschutt
Remove cranelift from sys-default feature
eb12cef 
When using the Wasmer-WASI crate, the sys-default feature from
wasmer is depending upon, which causes the following to conflict:

[dependencies.wasmer]
version = "2.0"
default-features=false
features=["sys" , "compiler-singlepass", "engine-universal"]

[dependencies.wasmer-wasi]
version = "2.0"

Because wasmer-wasi "2.0" depends on wasmer with the default features,
which implies using cranelift, which conflicts with singlepass.

Fixes #2882
fschutt added a commit that referenced this issue Jul 5, 2022
@fschutt
Remove cranelift from sys-default feature
df0b2f5 
When using the Wasmer-WASI crate, the sys-default feature from
wasmer is depending upon, which causes the following to conflict:

[dependencies.wasmer]
version = "2.0"
default-features=false
features=["sys" , "compiler-singlepass", "engine-universal"]

[dependencies.wasmer-wasi]
version = "2.0"

Because wasmer-wasi "2.0" depends on wasmer with the default features,
which implies using cranelift, which conflicts with singlepass.

Fixes #2882
fschutt added a commit that referenced this issue Jul 5, 2022
@fschutt
Remove cranelift from sys-default feature
4a86f5d 
When using the Wasmer-WASI crate, the sys-default feature from
wasmer is depending upon, which causes the following to conflict:

[dependencies.wasmer]
version = "2.0"
default-features=false
features=["sys" , "compiler-singlepass", "engine-universal"]

[dependencies.wasmer-wasi]
version = "2.0"

Because wasmer-wasi "2.0" depends on wasmer with the default features,
which implies using cranelift, which conflicts with singlepass.

Fixes #2882
fschutt added a commit that referenced this issue Jul 5, 2022
@fschutt
Remove cranelift from sys-default feature
a43803f 
When using the Wasmer-WASI crate, the sys-default feature from
wasmer is depending upon, which causes the following to conflict:

[dependencies.wasmer]
version = "2.0"
default-features=false
features=["sys" , "compiler-singlepass", "engine-universal"]

[dependencies.wasmer-wasi]
version = "2.0"

Because wasmer-wasi "2.0" depends on wasmer with the default features,
which implies using cranelift, which conflicts with singlepass.

Fixes #2882
fschutt added a commit that referenced this issue Jul 5, 2022
@fschutt
Remove cranelift from sys-default feature
7303b82 
When using the Wasmer-WASI crate, the sys-default feature from
wasmer is depending upon, which causes the following to conflict:

[dependencies.wasmer]
version = "2.0"
default-features=false
features=["sys" , "compiler-singlepass", "engine-universal"]

[dependencies.wasmer-wasi]
version = "2.0"

Because wasmer-wasi "2.0" depends on wasmer with the default features,
which implies using cranelift, which conflicts with singlepass.

Fixes #2882
fschutt added a commit that referenced this issue Jul 6, 2022
@fschutt
Remove cranelift from sys-default feature
49551d6 
When using the Wasmer-WASI crate, the sys-default feature from
wasmer is depending upon, which causes the following to conflict:

[dependencies.wasmer]
version = "2.0"
default-features=false
features=["sys" , "compiler-singlepass", "engine-universal"]

[dependencies.wasmer-wasi]
version = "2.0"

Because wasmer-wasi "2.0" depends on wasmer with the default features,
which implies using cranelift, which conflicts with singlepass.

Fixes #2882
@epilys epilys linked a pull request Jul 21, 2022 that will close this issue
Remove cranelift dependency from wasmer-wasi #3030
Merged
1 task
@bors bors bot closed this as completed in #3030 Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fschutt fschutt

Labels
bug Something isn't working 🍋 Low-hanging Fruit priority-low Low priority issue priority-medium Medium priority issue
Projects
None yet
Milestone
v3.0
3 participants
@syrusakbary @epilys @fschutt