Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RuntimeError::raise from public API #3003

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Remove RuntimeError::raise from public API #3003

merged 1 commit into from
Jul 5, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Jul 4, 2022 •
edited
Loading

Removes RuntimeError::raise (function was already depreceated for a relatively long time).

Review

  • Add a short description of the change to the CHANGELOG.md file

@fschutt fschutt requested a review from syrusakbary as a code owner July 4, 2022 13:42
@fschutt fschutt requested a review from epilys July 4, 2022 13:43
@fschutt fschutt mentioned this pull request Jul 4, 2022
Closed
1 task
@fschutt fschutt force-pushed the remove-runtime-raise-2 branch from 418d963 to 91bc782 Compare July 4, 2022 14:11
@epilys epilys linked an issue Jul 4, 2022 that may be closed by this pull request
Remove RuntimeError::raise because it's unsoundness #2914
Closed
@epilys epilys force-pushed the remove-runtime-raise-2 branch from 91bc782 to 220751a Compare July 5, 2022 11:13
@epilys
Copy link
Contributor

epilys commented Jul 5, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 5, 2022

Build succeeded:

@bors bors bot merged commit e32ecdf into master Jul 5, 2022
@bors bors bot deleted the remove-runtime-raise-2 branch July 5, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epilys epilys epilys approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove RuntimeError::raise because it's unsoundness
2 participants
@fschutt @epilys