Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RuntimeError::raise because it's unsoundness #2914

Closed
syrusakbary opened this issue Jun 1, 2022 · 2 comments · Fixed by #3003
Closed

Remove RuntimeError::raise because it's unsoundness #2914

syrusakbary opened this issue Jun 1, 2022 · 2 comments · Fixed by #3003
Assignees
@fschutt
Labels
🎉 enhancement New feature!
Milestone
v3.0

Comments

@syrusakbary
Copy link
Member

Remove RuntimeError::raise.
It’s an unsound function. Currently only used in JS, and it should be safe to use however in deprecated it on master and it’s not yet fully removed - APIs on sys/js should be consistent
@syrusakbary syrusakbary added the 🎉 enhancement New feature! label Jun 1, 2022
@syrusakbary syrusakbary added this to the v3.0 milestone Jun 1, 2022
@syrusakbary
Copy link
Member Author

This issue depends on #2912 refactor. Once it's done we can work on this

@syrusakbary
Copy link
Member Author

We just need to transform the functions that use RuntimeError::raise to return a Result with an error instead

@syrusakbary syrusakbary assigned fschutt and unassigned epilys Jun 29, 2022
@epilys epilys linked a pull request Jul 4, 2022 that will close this issue
Remove RuntimeError::raise from public API #3003
Merged
1 task
@bors bors bot closed this as completed in #3003 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fschutt fschutt

Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Remove RuntimeError::raise from public API wasmerio/wasmer
3 participants
@syrusakbary @epilys @fschutt