Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to using custom LLVM builds on CI #2949

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

silwol
Copy link
Contributor

@silwol silwol commented Jun 14, 2022

Closes: #2921

Description

Switch back to using the custom LLVM builds from wasmerio/llvm-custom-builds.

This will remove the dependency of binaries to libtinfo5, verified that in a VM.

Review

  • Add a short description of the change to the CHANGELOG.md file

@silwol silwol changed the title Switch back to using custom LLVM builds Switch back to using custom LLVM builds on CI Jun 14, 2022
@silwol silwol force-pushed the silwol/reactivate-custom-llvm branch 2 times, most recently from 8ddddd7 to f1b9ebd Compare June 14, 2022 08:15
@silwol silwol marked this pull request as ready for review June 14, 2022 09:04
@silwol silwol requested review from epilys and syrusakbary June 14, 2022 09:05
Copy link
Contributor

@epilys epilys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to result in only linux-amd64 and macos-amd64 using the llvm build (you can see that by going to the make build-wasmer step and see what compiler feature flags it ends up using

https://github.com/wasmerio/wasmer/actions/runs/2493814170

Copy link
Contributor

@epilys epilys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, on the llvm builds repository the new build artifacts aren't uploaded as Releases, hence the urls used here are from November 2021

@silwol
Copy link
Contributor Author

silwol commented Jun 14, 2022

Also, on the llvm builds repository the new build artifacts aren't uploaded as Releases, hence the urls used here are from November 2021

The release tag is from November 2021, but that only contained the source tarballs. The change in Adjust CI for reactivation of custom llvm builds built the releases and attached the artifacts to the release tag, see llvm-custom-builds release 13.x.

@epilys
Copy link
Contributor

epilys commented Jun 14, 2022

The release tag is from November 2021, but that only contained the source tarballs. The change in Adjust CI for reactivation of custom llvm builds built the releases and attached the artifacts to the release tag, see llvm-custom-builds release 13.x.

Oh you're right, missed the upload dates.

@silwol
Copy link
Contributor Author

silwol commented Jun 14, 2022

This seems to result in only linux-amd64 and macos-amd64 using the llvm build (you can see that by going to the make build-wasmer step and see what compiler feature flags it ends up using

Looking into that…

@silwol silwol marked this pull request as draft June 14, 2022 09:26
@silwol silwol force-pushed the silwol/reactivate-custom-llvm branch 5 times, most recently from 1b0f1b0 to 8f813db Compare June 20, 2022 18:12
@silwol silwol marked this pull request as ready for review June 21, 2022 06:03
@silwol silwol requested a review from epilys June 21, 2022 11:55
@epilys epilys force-pushed the silwol/reactivate-custom-llvm branch from 8f813db to afa2476 Compare June 21, 2022 12:58
@epilys
Copy link
Contributor

epilys commented Jun 21, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 21, 2022

Build succeeded:

@bors bors bot merged commit 1667998 into master Jun 21, 2022
@bors bors bot deleted the silwol/reactivate-custom-llvm branch June 21, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use custom LLVM builds
2 participants