-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch back to using custom LLVM builds on CI #2949
Conversation
8ddddd7
to
f1b9ebd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to result in only linux-amd64
and macos-amd64
using the llvm build (you can see that by going to the make build-wasmer
step and see what compiler feature flags it ends up using
https://github.com/wasmerio/wasmer/actions/runs/2493814170
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, on the llvm builds repository the new build artifacts aren't uploaded as Releases, hence the urls used here are from November 2021
The release tag is from November 2021, but that only contained the source tarballs. The change in Adjust CI for reactivation of custom llvm builds built the releases and attached the artifacts to the release tag, see llvm-custom-builds release 13.x. |
Oh you're right, missed the upload dates. |
Looking into that… |
1b0f1b0
to
8f813db
Compare
8f813db
to
afa2476
Compare
bors r+ |
Build succeeded: |
Closes: #2921
Description
Switch back to using the custom LLVM builds from wasmerio/llvm-custom-builds.
This will remove the dependency of binaries to
libtinfo5
, verified that in a VM.Review